dfaure added a comment.
Urgh. bool members as used here to share state between methods, with the assumption that they're always called together and in a certain order, are very brittle. If KDirOperator is a child widget, and it receives and processes a key event, it can choose to NOT let the event propagate to the parent widget [by calling accept() on the QKeyEvent, or returning false from event(), or true from eventFilter(), depending on how the event is processed -- isn't Qt easy? ;-)] REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25420 To: meven, #frameworks, ngraham, elvisangelaccio, dfaure Cc: ahmadsamir, feverfew, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
