cgiboudeaux requested changes to this revision. cgiboudeaux added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > CMakeLists.txt:35 > PROPERTIES > - URL "http://sphinx-doc.org/"; > + URL "https://sphinx-doc.org/"; > DESCRIPTION "Tool to generate documentation." 404. Please check > FindCanberra.cmake:98 > DESCRIPTION "Event sound library" > - URL "http://0pointer.de/lennart/projects/libcanberra"; > + URL "https://0pointer.de/lennart/projects/libcanberra"; > ) redirects to http://http://0pointer.net/ which is probably wrong. > KDEInstallDirs.cmake:250 > # - we are on a 64 bits system > -# reason is: amd64 ABI: http://www.x86-64.org/documentation/abi.pdf > +# reason is: amd64 ABI: https://www.x86-64.org/documentation/abi.pdf > # For Debian with multiarch, use 'lib/${CMAKE_LIBRARY_ARCHITECTURE}' if expired certificate, I recommend keeping http > clang-format.cmake:29 > > -# base is WebKit coding style: http://www.webkit.org/coding/coding-style.html > +# base is WebKit coding style: > https://www.webkit.org/coding/coding-style.html > # below are only things set that diverge from this style! This address is now redirected to https://webkit.org/code-style-guidelines/ REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns
