ahmadsamir added inline comments.

INLINE COMMENTS

> dhaumann wrote in kautosavefiletest.cpp:98
> What I wonder is: PATH_MAX etc are #defines, right? Since on Windows there is 
> a registry flag to enable much longer paths/file names. My intention is not 
> to block this series of patches, but we might end up with restrictions in our 
> code that do not exist on the filesystem at hand.

On windows the extended-length path is 32,767[1] characters, which is a bit 
unreasonable. I only skimmed those docs though.

[1] https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file

FTR, according to lxr.kde.org KAutoSaveFile is used by kdenlive, lokalize and 
libkeduvocdocument.

REPOSITORY
  R244 KCoreAddons

BRANCH
  l-kautosave-unittest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25767

To: ahmadsamir, #frameworks, mpyne, dfaure
Cc: dhaumann, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Reply via email to