ervin added inline comments.

INLINE COMMENTS

> settings.h:343
>  
> +    QList<KCoreConfigSkeleton *> configSkeletons() const;
> +

Will need API documentation

> broulik wrote in settings.h:343
> Not a fan of this becoming public API

@broulik I understand you don't like much this becoming exposed as one could 
abuse it to kill encapsulation and state... but we can't have it both ways 
either. This facade makes it impossible to plug as is in existing systems 
around KCM or ConfigModule without large efforts. I don't think we can have it 
both ways here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to