apol added inline comments. INLINE COMMENTS
> scalabletest.cpp:312 > QTextStream stream(&msg); > - stream << "Duplicated scalable icons:" << endl; > - for (auto icon : duplicatedScalableIcons.keys()) { > - stream << QString(" %1:").arg(icon) << endl; > - for (auto info : duplicatedScalableIcons[icon]) { > - stream << QString(" %1").arg(info.absoluteFilePath()) > << endl; > + stream << "Duplicated scalable icons:" << "\n"; > + for (const auto &icon : duplicatedScalableIcons.keys()) { '\n' or merge into the string. > scalabletest.cpp:319 > } > + stream.flush(); > QFAIL(qPrintable(msg)); Maybe add a {}-scope? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26318 To: mlaurent, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns