Followed your collective advice. So, this is FYI. Thanks a lot! -------- Original Message -------- Subject: Re: Review Request: Fix compilation with GCC 4.3+ in uiserver.h Date: Mon, 14 Jun 2010 14:52:23 -0000 From: Allen Winter <[email protected]> To: Allen Winter <[email protected]>, KDE PIM <[email protected]>, [email protected] References: <20100614055832.21426.2...@localhost>
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4294/#review6111 ----------------------------------------------------------- Ship it! Thanks. I just committed your patch to the enterprise4 branch and I will commit to all the other branches as well. you can close this review now. - Allen On 2010-06-14 05:58:32, avgapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4294/ > ----------------------------------------------------------- > > (Updated 2010-06-14 05:58:32) > > > Review request for KDE PIM. > > > Summary > ------- > > Fix build with GCC 4.3+ - uiserver.h references type FILE but doesn't include > any header file that makes its declaration visible. > This information might relevant too: > http://gcc.gnu.org/gcc-4.3/porting_to.html > > > Diffs > ----- > > > svn://anonsvn.kde.org/home/kde/branches/kdepim/enterprise4/kdepim/kleopatra/uiserver/uiserver.h > 1137726 > > Diff: http://reviewboard.kde.org/r/4294/diff > > > Testing > ------- > > > Thanks, > > avgapon > > -- Andriy Gapon _______________________________________________ kde-freebsd mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
