on 26/02/2011 18:33 Andriy Gapon said the following: > > Very minor issue really. > Whatever kind of optical disk I insert KDE 4 just shows its label, but never a > nice-looking icon. > Examples with a CD-RW disk: > http://people.freebsd.org/~avg/cd-noicon.png > http://people.freebsd.org/~avg/cd-noicon1.png > "TRANT rXXXX" is a label of an ISO filesystem on the disk. > > Am I alone with this issue?
I guess that I wasn't but everyone is too busy (embarassed?) to discuss this issue :) So it seems that the problem is between the solid library and our hal. In kdelibs4, in the file solid/solid/backends/hal/haldevice.cpp, there is the function 'QString HalDevice::icon() const' that returns an icon name based on information that hal provides about a device. The function expects that for optical disks "info.category" would be "volume" and "info.capabilities" would contain "volume.disc". But our hal gives "volume.disc" value in the info.category property as I can see with lshal. And thus the match fails and an empty icon name is returned from the function. I've just double-checked with OpenSUSE installation that I have and their hal supplies the values that the solid code expects. BTW, the similar mismatch exists also for an optical drive itself. With linux hal info.category is "storage" and info.capabilities contains "storage.cdrom", but with our hal info.category is "storage.cdrom". Not sure if the upcoming KDE 4.6.1 will be affected (i.e. if it still uses hal backend). But I think that our hal is still worth fixing. Thanks! -- Andriy Gapon
_______________________________________________ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
