The following reply was made to PR ports/186707; it has been noted by GNATS.
From: Max Brazhnikov <[email protected]> To: Tijl Coosemans <[email protected]> Cc: [email protected] Subject: Re: ports/186707: [patch] devel/qt4-corelib: fix iconv detection Date: Sun, 23 Mar 2014 19:02:46 +0000 On Thu, 20 Mar 2014 14:41:19 +0100 Tijl Coosemans wrote: > On Sun, 09 Mar 2014 16:37:51 +0000 Max Brazhnikov wrote: > > On Thu, 06 Mar 2014 23:12:06 +0100 Tijl Coosemans wrote: > >> It would be nice to fix all qt4 ports so they all respect CXXFLAGS > >> during configure (build phase is already ok), but I'm not sure where > >> in bsd.qt.mk a REINPLACE_CMD or something can be added to accomplish > >> this. > > > > You can use common EXTRA_PATCHES defined in bsd.qt.mk for Qt ports, > > the patches are stored in devel/qt4. > > I've attached a patch that uses this. It also applies the patch to > qt5. qt5-core doesn't actually need iconv so the patch removes that > dependency. There's this in src/corelib/codecs/codecs.pri: > > contains(QT_CONFIG,icu) { > .... > } else { > .... use iconv ... > } > > And the port Makefile adds "icu" to QT_CONFIG. Then iconv can be explicitly disabled in qt5-core, please replace -no-feature-iconv with -no-iconv and commit with my approval. > Tested on redports: > qt4: https://redports.org/buildarchive/20140319203417-94556/ > qt5: https://redports.org/buildarchive/20140319203451-88592/ Thanks a lot for dipping into the problem and fixing it! Max _______________________________________________ kde-freebsd mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
