https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214184
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from [email protected] --- (In reply to Raphael Kubo da Costa from comment #9) Considering that I don't use Amarok at all and kinda despise it, it's not worth opening another PR. I was merely trying to clear the way for FFmpeg 3.x, and I was fixing other obvious issue encountered on the way. Although I like the idea of separate change sets for logically independent changes, that is just not practical for a contributor when PR handling times are measured in weeks if not months (this one took just over a month). Lumping all the changes for a port into a single PR is the only (somewhat) practical way to make measurable forwards progress. When I was testing the patch for newer FFmpeg, I built on a live system and I had turned off all the options in Amarok to minimize the dependencies. Of course, this caused me to notice any option that does not properly switch off, because the dependencies were present in the live build environment so the compilation will find and use those which are not properly disabled during the configure phase. Testing in Poudriere will NOT identify such problems unless you go out of your way to ensure the libraries are present in the build jail, i.e. temporarily make the all the depends non-optional. Without the change suggested by tcberner, Amarok is linking against libmtp if it's present regardless of the option state. That is incorrect and I have tested the proposed solution, but I'm already bending over backwards here and don't need to go further. I simply have more productive things to do than atomize fixes to software I'd rather just delete. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.
