Le Mardi 14 Mars 2006 17:09, Michaël Larouche a écrit : > The goal of this patch is to do less D-BUS calls as possible.
A few comments on the patch: 1) I would revert the if () for readability. If it's in the cache return it else ask hal. 2) For propertyExists() I would keep an entry holding QVariant() if HAL returned false. Otherwise you'll query HAL each time except if the property exists. 3) Calling allProperties() in the constructor is a bad idea IMHO. You'll keep in memory a lot of useless information. Moreover as soon as you'll get a PropertyModified() signal, the map you return from allProperties() is wrong. This part should definitely be rethought. Regards. -- Kévin 'ervin' Ottens, http://ervin.ipsquad.net "Ni le maître sans disciple, Ni le disciple sans maître, Ne font reculer l'ignorance."
pgp6r4BJ7tD76.pgp
Description: PGP signature
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
