-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5892/
-----------------------------------------------------------
Review request for Solid and Rafael Fernández López.
Summary
-------
Implement support for all attributes of the Processor interface when using UDev.
With this patch, the udev backend does better than the hal one (notably, with
linux 2.6.36, HAL's reporting of the throttling ability of a processor will
break, as /proc/acpi/CPUX/info is removed in that kernel version; also, HAL
does not report the processor vendor).
There doesn't appear to be a way of reliably getting information about the
CPU's throttling ability from sysfs - the only sysfs property that is
predicated on this is thermal_cooling/max_state, but only by increasing the
value in there.
It might be good to do some caching of values, since there is a lot of opening
and parsing files (although the opening and reading part should be fast on
virtual filesystems, and there isn't a whole lot of text to parse).
This addresses bug 253667.
https://bugs.kde.org/show_bug.cgi?id=253667
Diffs
-----
/trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1198123
/trunk/KDE/kdelibs/solid/solid/backends/shared/udevqt.h 1198123
/trunk/KDE/kdelibs/solid/solid/backends/shared/udevqtdevice.cpp 1198123
/trunk/KDE/kdelibs/solid/solid/backends/udev/cpuinfo.h PRE-CREATION
/trunk/KDE/kdelibs/solid/solid/backends/udev/cpuinfo.cpp PRE-CREATION
/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.h 1198165
/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp 1198165
/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp 1198165
/trunk/KDE/kdelibs/solid/solid/backends/udev/udevprocessor.cpp 1198165
Diff: http://svn.reviewboard.kde.org/r/5892/diff
Testing
-------
Reports information correctly on my computer.
Thanks,
Alex
_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
