----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100768/#review1801 -----------------------------------------------------------
Turns out Nikhil committed a similar patch last night. Please close this request and the corresponding BR. Thanks for the effort and pointing out the issue though. - Kevin On March 2, 2011, 5:40 p.m., Christopher Blauvelt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100768/ > ----------------------------------------------------------- > > (Updated March 2, 2011, 5:40 p.m.) > > > Review request for Solid and Kevin Ottens. > > > Summary > ------- > > The HUPnP backend does not compile with the most up-to-date version (0.9) of > HUPnP due to API changes. The ~HAsyncOp() function was made a pure virtual > function preventing direct use of the class. The class used was changed to > HClientActionOp. Additionally, the setUserData and userData functions were > removed from HAsyncOp. These functions were used to pass input arguments for > previously invoked functions. HClientActionOp provides a method to reference > these input parameters. > > > This addresses bug 267283. > http://bugs.kde.org/show_bug.cgi?id=267283 > > > Diffs > ----- > > solid/solid/backends/upnp/upnpinternetgateway.h 35f0c00 > solid/solid/backends/upnp/upnpinternetgateway.cpp 527efe8 > > Diff: http://git.reviewboard.kde.org/r/100768/diff > > > Testing > ------- > > None. What facilities exist to test UPnP devices? > > > Thanks, > > Christopher > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
