----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100815/#review2123 -----------------------------------------------------------
See comments below. Also for some reason you adjusted the other backends, except the UPnP one, it should need to be updated as well. solid/solid/deviceinterface.cpp <http://git.reviewboard.kde.org/r/100815/#comment1752> Should simply be "Network Share", not "NetworkShare Interface" IMO. solid/solid/networkshare.h <http://git.reviewboard.kde.org/r/100815/#comment1753> Should carry "@since 4.7" solid/solid/networkshare.h <http://git.reviewboard.kde.org/r/100815/#comment1754> Please add the URL or ID property as discussed today over IRC with Sebatian. - Kevin On March 9, 2011, 10:22 a.m., Mario Bensi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100815/ > ----------------------------------------------------------- > > (Updated March 9, 2011, 10:22 a.m.) > > > Review request for Solid. > > > Summary > ------- > > - Add the NetworkShare interface to determine the network protocol used. > - Use this interface in fstab backend to determine if we have a nfs or > smb mount point. > > > Diffs > ----- > > solid/solid/CMakeLists.txt 46adea8 > solid/solid/backends/fakehw/fakedevice.cpp 94455ed > solid/solid/backends/fstab/fstabdevice.cpp efc085d > solid/solid/backends/fstab/fstabmanager.cpp 68e8d8b > solid/solid/backends/fstab/fstabnetworkshare.h PRE-CREATION > solid/solid/backends/fstab/fstabnetworkshare.cpp PRE-CREATION > solid/solid/backends/hal/haldevice.cpp 56823f6 > solid/solid/backends/hal/haldeviceinterface.h 240017b > solid/solid/backends/udisks/udisksdeviceinterface.h 42a88a8 > solid/solid/backends/upower/upowerdeviceinterface.h 6608ab3 > solid/solid/backends/wmi/wmideviceinterface.h 99437e5 > solid/solid/backends/wmi/wmimanager.cpp 41c7274 > solid/solid/device.cpp 54135d8 > solid/solid/deviceinterface.h c04bbf4 > solid/solid/deviceinterface.cpp 375ae37 > solid/solid/ifaces/networkshare.h PRE-CREATION > solid/solid/ifaces/networkshare.cpp PRE-CREATION > solid/solid/networkshare.h PRE-CREATION > solid/solid/networkshare.cpp PRE-CREATION > solid/solid/networkshare_p.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/100815/diff > > > Testing > ------- > > > Thanks, > > Mario > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
