----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101270/#review3060 -----------------------------------------------------------
solid/solid/backends/udev/udevmanager.cpp <http://git.reviewboard.kde.org/r/101270/#comment2617> What about having this check only in createDevice()? Should give you the behavior you want without listing the devices like now if I'm not mistaken. - Kevin On May 2, 2011, 1:43 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101270/ > ----------------------------------------------------------- > > (Updated May 2, 2011, 1:43 p.m.) > > > Review request for Solid, Kevin Ottens and Alex Fiestas. > > > Summary > ------- > > solid-hardware does not report my 3G modem's vendor and model names. This > patch fix that: > > [lamarque@evolucao ~]$ solid-hardware details > /org/kde/solid/udev/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1 > udi = '/org/kde/solid/udev/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1' > parent = '/org/kde/solid/udev' (string) > vendor = 'Sony Ericsson' (string) > product = 'Sony Ericsson MD300' (string) > description = '' (string) > Block.major = 189 (0xbd) (int) > Block.minor = 175 (0xaf) (int) > Block.device = '/dev/bus/usb/002/048' (string) > > The patch basically tests if > /sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1 exists, if affirmative it > creates a UDevDevice, which makes it possible to report the available device > details instead of just ignoring them completely. > > 'solid-hardware list' still does not list the device. I am still not sure if > I should fix that since it would give the false impression the device is > supported. > > The motivation for this change is Plasma NM. The patch allows me inform > modem's vendor and model names > in Mobile Connection Wizard (when creating Gsm/Cdma connections) and in > PinDialog (when requesting PIN unlock code from user). It is basically > usability fix. > > > Diffs > ----- > > solid/solid/backends/udev/udevdevice.cpp 4f34382 > solid/solid/backends/udev/udevmanager.cpp e08fcde > > Diff: http://git.reviewboard.kde.org/r/101270/diff > > > Testing > ------- > > I have been using kdelibs-4.6.2 compiled with the patch since yesterday, not > problems so far. > > > Thanks, > > Lamarque Vieira > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
