----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101453/#review3596 -----------------------------------------------------------
Sry, but the patch doesn't make sense to me; I don't like the timeout approach and secondly, the check for optical drive is there on purpose, they are handled separately elsewhere. This special case is because of bug https://bugs.kde.org/show_bug.cgi?id=267398 - Lukáš On May 27, 2011, 7:50 p.m., Jacopo De Simoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101453/ > ----------------------------------------------------------- > > (Updated May 27, 2011, 7:50 p.m.) > > > Review request for Solid, Lukáš Tinkl and Ozan Çağlayan. > > > Summary > ------- > > Call DeviceEject only if the drive actually requires to be ejected, > moreover call the special eject routine if the drive IS an optical Disc, not > if it is NOT an optical disc… > > > This addresses bug 270490. > http://bugs.kde.org/show_bug.cgi?id=270490 > > > Diffs > ----- > > solid/solid/backends/udisks/udisksstorageaccess.h > 6bf729cce4e5c5ec79fa82dd56fcd825d9f79515 > solid/solid/backends/udisks/udisksstorageaccess.cpp > 4cb0f7ceeee2f7a342346fd7507df6788a7bf82c > > Diff: http://git.reviewboard.kde.org/r/101453/diff > > > Testing > ------- > > > Thanks, > > Jacopo De > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
