----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102907/#review7472 -----------------------------------------------------------
This review has been submitted with commit 2e500b5f5edd177c8af187c9bfe077815e65b6e7 by Albert Astals Cid to branch KDE/4.7. - Commit Hook On Oct. 18, 2011, 4:36 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102907/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2011, 4:36 p.m.) > > > Review request for Solid. > > > Description > ------- > > When plugging my N950 solid reports > Nokia Nokia N950 as description for the device and shows in various places in > the UI (dolphin, device notifier) > I am suggesting removing the first Nokia > > My initial patch had > if (model.startsWith(vendor_str + " ")) > instead of > if (model.startsWith(vendor_str)) > I'm open to discussion on how to improve the check > > > Diffs > ----- > > solid/solid/backends/udisks/udisksdevice.cpp c76eebc > > Diff: http://git.reviewboard.kde.org/r/102907/diff/diff > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
