----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106686/#review19743 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Kügler On Oct. 2, 2012, 11:21 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106686/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2012, 11:21 a.m.) > > > Review request for Solid and Dario Freddi. > > > Description > ------- > > This patch fixes battery notification not being emitted due to early return, > and makes it watch for a change in ChargeState rather than the charge > percentage which might not be reached at all. > > > Diffs > ----- > > powerdevil/daemon/powerdevilcore.h 12e4b2c > powerdevil/daemon/powerdevilcore.cpp b968d21 > > Diff: http://git.reviewboard.kde.org/r/106686/diff/ > > > Testing > ------- > > Compiles. > Did not test if notification is properly emited, will do. Just wanted to know > if this is the right approach. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
