> On Oct. 10, 2012, 3:43 p.m., Lamarque Vieira Souza wrote: > > powerdevil/kcmodule/global/GeneralPage.cpp, line 135 > > <http://git.reviewboard.kde.org/r/106783/diff/4/?file=89033#file89033line135> > > > > Usually UpsBattery are connected to the computer through a USB cable. > > If the computer does not have any other battery when the USB cable is > > unpplugged those config options will be hidden. If the user hook up the > > UPS' USB cable while the kcm is already opened those options will still be > > invisible, right? You should make them visible in such case.
I didn’t touch that code at all. The previous version also didn’t enable them in such case. If you could point me to a signal that is emitted when such an event occurs, I could come up with something. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106783/#review20146 ----------------------------------------------------------- On Oct. 10, 2012, 3:35 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106783/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2012, 3:35 p.m.) > > > Review request for Solid. > > > Description > ------- > > This little patch hides the config options for battery levels altogether when > there is no battery present. Reducses visual clutter. > > > Diffs > ----- > > powerdevil/kcmodule/global/GeneralPage.cpp 5ff3f4d > > Diff: http://git.reviewboard.kde.org/r/106783/diff/ > > > Testing > ------- > > Didn’t test whether the elements are really hidden in the real condition > (Have a notebook only here, but I know that if works) but commented out the > if and the elements are all properly removed. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
