----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106864/#review20410 -----------------------------------------------------------
This review has been submitted with commit 66df6d8561560a8c238108ac4d18b8caf22de613 by Kai Uwe Broulik to branch KDE/4.9. - Commit Hook On Oct. 15, 2012, 4:40 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106864/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2012, 4:40 a.m.) > > > Review request for Solid. > > > Description > ------- > > It really took me two hours to find this bug but now I have found it: Seems > like a bug in Qt or in the Oxygen theme: When there is a QScrollArea inside a > QTabBar, and this QScrollArea contains a generated widget applied by > setWidget, this widget in the first tab of the tab list (and the default > selected one) are not opaque, making the gradient invisible. (Sorry, could > not describe better). > > After I found out that that ScrollArea is not needed at all but the QTabBar > provides scrollbars by itself, I removed all that stuff, and just added a > QGridLayout (first thing I could think of that could hold widgets) to hold > our EditWidget. Now all the backgrounds are correct. > > And this patch also has a little positive side-effect: The config dialog of > the battery plasmoid is now initially sized properly. > > > This addresses bug 307648. > http://bugs.kde.org/show_bug.cgi?id=307648 > > > Diffs > ----- > > powerdevil/kcmodule/profiles/EditPage.cpp 95a98d9 > powerdevil/kcmodule/profiles/profileEditPage.ui cc99e9b > > Diff: http://git.reviewboard.kde.org/r/106864/diff/ > > > Testing > ------- > > Opened the dialog, the "ON AC Power" tab has proper background. When resizing > the dialog, scroll bars appear. It also works when the tabbar is hidden (when > no batteries present - just saw: the battery detection code could be > simplified like in the other KCM (hasBattery rather than batteryCount)). > > > Screenshots > ----------- > > Proof screenshot :) > http://git.reviewboard.kde.org/r/106864/s/772/ > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
