-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107505/
-----------------------------------------------------------

Review request for Solid.


Description
-------

I made PowerDevil show the battery low and critical notifications directly on 
startup so you cannot miss them. However, I complained about that DPMS profile 
warning and then added another notification that appears right on startup :P
Because of the nature of the notifications which are emitted in the 
onDeviceAdded part, it is emitted when PowerDevil comes up, leading to a 
similar ugly notification. This patch suppresses any notifications from 
onDeviceAdded until the checkBatteryStatus slot is fired, and then emits the 
notifications as needed.

CCBUG: 261890


Diffs
-----

  powerdevil/daemon/powerdevilcore.h 77c3f2f 
  powerdevil/daemon/powerdevilcore.cpp 2dcdbc6 

Diff: http://git.reviewboard.kde.org/r/107505/diff/


Testing
-------

Tested with AC unplugged, logged in, no notification, after 30 seconds in the 
workspace, I got a notification saying my battery is low.


Thanks,

Kai Uwe Broulik

_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Reply via email to