-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107940/
-----------------------------------------------------------
(Updated Jan. 9, 2013, 9:10 p.m.)
Review request for Solid, Àlex Fiestas and Dan Vrátil.
Changes
-------
Adding bug entries that this patch fixes.
Description
-------
The change in XRandROutput::edid() allows us to use "if (edid->isValid())"
instead of "if (edid && edid->isValid())". I think the former is cleaner.
The change in XRandROutput::updateModes() selects the first preferred mode
found instead of the last one. At least in my notebook the first preferred mode
has higher resolution, probably that is also valid for all modes returned by
XRandR API.
This addresses bugs 312236 and 312951.
http://bugs.kde.org/show_bug.cgi?id=312236
http://bugs.kde.org/show_bug.cgi?id=312951
Diffs
-----
backends/xrandr/xrandroutput.cpp dc2555b
Diff: http://git.reviewboard.kde.org/r/107940/diff/
Testing
-------
Tested in my notebook. The change in XRandROutput::edid() is part of a crash
fix for kscreen. The change in XRandROutput::updateModes() fixes a problem in
my notebook's lcd, which includes several preferred modes and the last mode is
the one with lower resolution.
Thanks,
Lamarque Vieira Souza
_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
