-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108351/#review25265
-----------------------------------------------------------
Ship it!
Regarding the 'primary' update, I was considering a different approach than
just a bool, possibly an enum { SetPrimary, UnsetPrimary, NoChange } so that
you could call XRandROutput::update(NoChange) from crtcChanged() and
XRandROutput::update((output == primary) ? SetPrimary : UnsetPrimary) from
outputChanged(). I'll try to do this during weekend before tagging :-)
- Dan Vrátil
On Jan. 11, 2013, 3:43 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108351/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2013, 3:43 p.m.)
>
>
> Review request for Solid and Dan Vrátil.
>
>
> Description
> -------
>
> Basically call XRandR::updateOutput(RROUtput) on every
> XRandR::updateCrtc(RRCrtc)
>
> This is a little bit inneficient since we don't have a way of updating an
> output without checking if the primary screen changed (that can't happen in a
> crtc update) but anyway a minor thing imho.
>
>
> Diffs
> -----
>
> backends/xrandr/xrandr.cpp 0113671
>
> Diff: http://git.reviewboard.kde.org/r/108351/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
