----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108415/#review25534 -----------------------------------------------------------
This review has been submitted with commit 32dd6e46e094769f2e6464a09aaf436509cf3921 by Jeremy Whiting to branch master. - Commit Hook On Jan. 14, 2013, 7 p.m., Jeremy Paul Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108415/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 7 p.m.) > > > Review request for Solid, Àlex Fiestas and Dan Vrátil. > > > Description > ------- > > Since the enumeration for rotation in libkscreen was backwards between right > and left the order for rotating in the kcm was also backwards (Counter > clockwise was going normal -> right -> inverted -> left, which was wrong, but > right because the enumeration was backwards also). This fixes the order so > the enumeration can also be fixed at the same time. > > Also, note xrandr rotation angles are counter clockwise, while qml rotations > are clockwise. > > > Diffs > ----- > > kcm/qml/Output.qml 0fb3cec701b8ded7e11f1e57a02b82fa48c0d579 > kcm/qml/OutputControls.qml fb743ad15a28862d6ff41bd09a6c51049e473e16 > > Diff: http://git.reviewboard.kde.org/r/108415/diff/ > > > Testing > ------- > > It works fine here. Also tested it was working fine before with the old > enumeration values, but once those were fixed this was backwards. > > > Thanks, > > Jeremy Paul Whiting > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
