> On April 30, 2012, 4:09 p.m., Lukáš Tinkl wrote: > > Has this been submitted? > > Christoph Feck wrote: > No, I did not get any feedback from maintainers. Not sure if it still > makes sense, because Dolphin 4.9 gets a new places panel, not based on > KFilePlacesView. The patch probably also does not fix the spin-up behavior, > because that seems to be caused by Solid's icon determination code, according > to comments in mentioned bug reports.
I guess this can be closed now; the spin-up misbehavior is fixed in Solid/udisks2 and Dolphin has different code as you said - Lukáš ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103682/#review13134 ----------------------------------------------------------- On Jan. 12, 2012, 5:42 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103682/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2012, 5:42 p.m.) > > > Review request for Dolphin, kdelibs and Solid. > > > Description > ------- > > I only tried to fix the double/blurry text (bug 248062), but stumbled upon a > possible reason for the unwanted spin-up behavior reported in the other bugs. > According to the code, the KFreeDiskSpaceInfo object is queried even if we do > not display the capacity bar. > > The attached patch should fix it: > - the text is not faded at two positions, but moved between those two > positions > - the KFreeDiskSpaceInfo object is only created if we indeed want to show the > capacity bar > > I tried to separate the patches for those two issues, but it was not possible. > > Please review. > > > This addresses bugs 184449, 248062, 261552, 264487, and 268103. > http://bugs.kde.org/show_bug.cgi?id=184449 > http://bugs.kde.org/show_bug.cgi?id=248062 > http://bugs.kde.org/show_bug.cgi?id=261552 > http://bugs.kde.org/show_bug.cgi?id=264487 > http://bugs.kde.org/show_bug.cgi?id=268103 > > > Diffs > ----- > > kfile/kfileplacesview.cpp 6a343b3 > > Diff: http://git.reviewboard.kde.org/r/103682/diff/ > > > Testing > ------- > > > Thanks, > > Christoph Feck > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
