> On March 7, 2013, 10:25 a.m., Lukáš Tinkl wrote:
> > Slightly wrong; for the resume signal, you really need to check for version 
> > > 197

Ok. Patch adjusted


- Raymond


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109336/#review28753
-----------------------------------------------------------


On March 7, 2013, 10:46 a.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109336/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 10:46 a.m.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Description
> -------
> 
> With KDE 4.10.1 Lukas pushed a patch into PowerDevil to support the new 
> systemd capabilities for suspend and hibernate. The patch is checking in a 
> few places only if systemd is present and available, but forgets to check the 
> version. With older distro versions, that still have an old systemd version 
> this leads to issues where PowerDevil wrongly assumes that systemd can 
> provide the necessary functionality. The end result is that the options to 
> hibernate or suspend are no longer available for the user. 
> 
> This small patch checks consistently the version of systemd to ensure that 
> the correct version of systemd is being used. 
> 
> 
> This addresses bug 316219.
>     http://bugs.kde.org/show_bug.cgi?id=316219
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp f9503b3 
> 
> Diff: http://git.reviewboard.kde.org/r/109336/diff/
> 
> 
> Testing
> -------
> 
> The patch was provided to a couple of openSUSE users that were running KDE 
> 4.10.1 on openSUSE 12.2 (which shipped systemd version 44) and experienced 
> the above mentioned issue. With the patch the correct behavior was restored 
> again 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Reply via email to