> On March 16, 2013, 9:56 p.m., Àlex Fiestas wrote: > > Besides the spaces (reviewboard paints a big red square for them xD) > > everything seems ok, at least code wise. > > > > I have yet to learn all the changes in BlueZ so I can't really evaluate > > whether your changes are correct or not, but from what I have read (in your > > code and in BlueZ documentation) everything looks fine. > > > > Please, commit this into a branch within the libbluedevil repository > > (bluez5 ?) so we can prepare everything for a release. > > > > This is a little sheet we use before each release to make sure that > > everything works: > > http://community.kde.org/Solid/Projects/BlueDevil/Tests > > > > As soon as all works with bluez5 we can make a first release. > > > > Again, really great job ! I'm really looking forward at > > BlueDevil/libbluedevil 2.0
Oh additionally I have subscribed you in kde-hardware-devel so we can discuss there how to continue, coordinate with distributions etc. If we stop doing BlueZ4 releases distributions will kill us :p - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108912/#review29338 ----------------------------------------------------------- On March 16, 2013, 3:34 p.m., Daniel Schaal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108912/ > ----------------------------------------------------------- > > (Updated March 16, 2013, 3:34 p.m.) > > > Review request for Bluedevil. > > > Description > ------- > > * Use DBus ObjectManager to get Adapter/Devices (inspired by solid's udisks2 > backend) > * remove cached properties, directly use DBus properties > * add unpairedDeviceFound signal to Adapter > * move [un]registerAgent to Manager > * Update DBus interfaces for Bluez 5 > * Remove default adapter methods. > > git repo available on > http://quickgit.kde.org/?p=clones/libbluedevil/schaal/libbluedevil.git > > References: > > http://www.bluez.org/bluez-5-api-introduction-and-porting-guide/ > https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc > > > Diffs > ----- > > CMakeLists.txt 5fb5039bc88ab7f53e2c3f0b0ba066892efbbda3 > bluedevil/CMakeLists.txt 766d603b8dec09bef31fcee9cba7eb4ef7e3d5f4 > bluedevil/bluedevil.h 798068b76e69c70ec3b208cfdbf4fad532862aea > bluedevil/bluedeviladapter.h 65e5a4babdb13068f4f371aca818aa99b5a1921e > bluedevil/bluedeviladapter.cpp 740ccb796baee1e05c6677243a30e9330e207017 > bluedevil/bluedevildbustypes.h PRE-CREATION > bluedevil/bluedevildevice.h 003aa027b29f7a98bbb01d60dc626ed4b02588a9 > bluedevil/bluedevildevice.cpp dafc130af7ab6fbf66dd33c0508ae78d71bde9aa > bluedevil/bluedevilmanager.h 0386b8ef187ad0cd06f51436f8d4feb916ca74e3 > bluedevil/bluedevilmanager.cpp e6344320783895536aa1fea4d71f58fcc4f3cf41 > bluedevil/bluez/bluez-adapter.xml 5535fff2d00f79e6bb12d4f7d77b40a16d5fe9ee > bluedevil/bluez/bluez-device.xml 74ac0816cb4058d08024da93fe27616e138f8294 > bluedevil/bluez/bluez-manager.xml fe7fcbe5f750c0f065c8dff98bf777f7b3d2ebf2 > bluedevil/bluez/doc/adapter-api.txt > 6098c765e33ff085093f26ce84df2aee07315f40 > bluedevil/bluez/doc/agent-api.txt d8d35c05a923b7ccb23370f17e9aeff516233807 > bluedevil/bluez/doc/audio-api.txt e7991f336f76e151c645d422a6abd4764623c8fd > bluedevil/bluez/doc/bluez-docs.xml 74a8bd1918689671b73c54aa1bbad5f2241ff3be > bluedevil/bluez/doc/control-api.txt > 1a42846ad096f8a0caa5267627ff03382e762563 > bluedevil/bluez/doc/device-api.txt b8182997392d2d66a2e60fdcf929502056e468f1 > bluedevil/bluez/doc/gtk-doc.make 354ffb7c66c4e6151ed126f63320d03f7b21d6b3 > bluedevil/bluez/doc/hfp-api.txt 93251e83f4435c30408eba1c862b116735d8388e > bluedevil/bluez/doc/input-api.txt 7c3a4b23e542dbd70ebf5d314cdc971726407f82 > bluedevil/bluez/doc/manager-api.txt > d2c1cafe46b6535efd6c2d9ebf968feba122e25b > bluedevil/bluez/doc/network-api.txt > eca60d4f3c683e4de3c38dad4f458d5c3d99b0ac > bluedevil/bluez/doc/node-api.txt 3ae4deef9e398aaf81844be2c2e39394a2ccd9e2 > bluedevil/bluez/doc/serial-api.txt 5f9bd5f2ccd23b1b37e066b553b5ff60c271ceb7 > bluedevil/bluez/doc/service-api.txt > 5c8c7f37280301162abf4dc09800bd9f5a2bd255 > bluedevil/bluez/doc/version.xml.in d78bda93422ecbbca8caf772f7b37f8fe3b254e9 > bluedevil/bluez/org.bluez.Adapter1.xml PRE-CREATION > bluedevil/bluez/org.bluez.AgentManager1.xml PRE-CREATION > bluedevil/bluez/org.bluez.Device1.xml PRE-CREATION > bluedevil/bluez/org.freedesktop.DBus.ObjectManager.xml PRE-CREATION > bluedevil/bluez/org.freedesktop.DBus.Properties.xml PRE-CREATION > bluedevil/test/adaptertest.h 0521fe165ae34aaf86f7e61149452389ad9bb644 > bluedevil/test/adaptertest.cpp fd1ab818d3318e75b88c1e94e7f09fc8aa9f6cee > bluedevil/test/bluedeviltest.cpp 2d3d0e2cd5d9f986802b2c3728bdf013fd7b84b0 > > Diff: http://git.reviewboard.kde.org/r/108912/diff/ > > > Testing > ------- > > adaptertest: > * added/removed a (virtual) adapter > * started/stopped bluetoothd > > bluedeviltest: > * scanning for a device and removing a device > > pairing wizard from bluedevil: > * pairing a headset device > > > Thanks, > > Daniel Schaal > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
