----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110607/#review34096 -----------------------------------------------------------
solid/solid/ifaces/battery.h <http://git.reviewboard.kde.org/r/110607/#comment25045> Is this header file private? Note that adding virtual member functions is not binary compatible. - Christoph Feck On June 4, 2013, 1:40 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110607/ > ----------------------------------------------------------- > > (Updated June 4, 2013, 1:40 p.m.) > > > Review request for Solid. > > > Description > ------- > > This patch adds support for the capacity property of batteries that tells how > much energy can the battery hold compared to what it is designed to. > > > Diffs > ----- > > solid/solid/backends/fakehw/fakebattery.h 3ab180b > solid/solid/backends/fakehw/fakebattery.cpp d1907f6 > solid/solid/backends/hal/halbattery.h 15590ad > solid/solid/backends/hal/halbattery.cpp d91a524 > solid/solid/backends/upower/upowerbattery.h 576e06e > solid/solid/backends/upower/upowerbattery.cpp da0b877 > solid/solid/battery.h 9a0929e > solid/solid/battery.cpp b3016cc > solid/solid/ifaces/battery.h 971914f > > Diff: http://git.reviewboard.kde.org/r/110607/diff/ > > > Testing > ------- > > Compiles. > Needs more testing. On my machine with recentmost UPower (or probably because > I broken something) it does not return energy-full-design (which is needed > obviously) which makes it fallback to 100% capacity. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
