Dne 29.6.2013 16:56, Daniel Nicoletti napsal(a):
I'm sorry but IMO this is shouldn't be made this way.
* Do you really want to carry an option to import old secrets?
* Till when this option will be there, Debian users normally jump lots
of releases...
* What if the user decides to use the old applet? It won't work
because the new secrets are in the new format.
IMHO or the same format is used (I don't see why not), or don't import
the secrets at all.
my 2¢
This patch already uses the old format, but we (even you) implemented a
different format before in our secret agent. I just submitted this patch
for review to inform you about changes. The only thing I'm doing is
importing of secrets stored in files (not in KWallet) and saving them
into KWallet (if it's enabled) or into one file like you implemented in
secret agent.
2013/6/29 Jan Grulich <[email protected] <mailto:[email protected]>>
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111295/
Review request for Solid, Lukáš Tinkl and Lamarque Souza.
By Jan Grulich.
/Updated June 29, 2013, 8:11 a.m./
Changes
Updated again, I was too hurried. Anyway, I think I could already push this
:)
Description
As I promised, here is a patch that should fix secrets compatibility between both NM applets.
But there is one little difference which is that VPN secrets has "secrets" key in KWallet
entry (according to VPN setting property) instead of "VpnSecrets". Everything is done
automatically at first start and there is no information about how many secrets were imported etc.
Diffs (updated)
* editor/connectioneditor.h (f8fb13f)
* editor/connectioneditor.cpp (ee352d2)
* kded/secretagent.cpp (dc6f648)
View Diff <http://git.reviewboard.kde.org/r/111295/diff/>
_______________________________________________
Kde-hardware-devel mailing list
[email protected] <mailto:[email protected]>
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
--
Daniel Nicoletti
KDE Developer - http://dantti.wordpress.com
Cheers,
Jan
--
Jan Grulich
Red Hat Czech, s.r.o
[email protected]
_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
