> On July 2, 2013, 6:30 p.m., Lamarque Souza wrote: > > smsinterface.cpp, line 145 > > <http://git.reviewboard.kde.org/r/111366/diff/3/?file=167583#file167583line145> > > > > Change this to: > > > > return d->smsIface->Send();
Yeah missed this.A bit careless > On July 2, 2013, 6:30 p.m., Lamarque Souza wrote: > > smsinterface.h, line 59 > > <http://git.reviewboard.kde.org/r/111366/diff/3/?file=167582#file167582line59> > > > > MMSmsStorage is defined in a ModemManager header > > (ModemManager-enums.h). For the sake of good documentation we should > > describe those enums in the doxygen comment (basically copy the comments in > > ModemManager-enums.h). The same is valid of MMSmsState, MMSmsPduType and > > MMSmsDeliveryState. > > > > Actually the approach that used to be done in Solid is to create new > > enums in camel case to replace the ones in NetworkManager's headers. We > > could do the same here, although that would be a pain to maintain. I would > > like hear the oppinion of other Solid members about this. Yeah, we need a consensus here. I had redefined enums earlier, but followed Lukas's pattern this time. - Anant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111366/#review35467 ----------------------------------------------------------- On July 2, 2013, 6:36 p.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111366/ > ----------------------------------------------------------- > > (Updated July 2, 2013, 6:36 p.m.) > > > Review request for Solid, Lukáš Tinkl and Lamarque Souza. > > > Description > ------- > > Implements > https://developer.gnome.org/ModemManager/0.7/gdbus-org.freedesktop.ModemManager1.Sms.html > Renamed accordingly. > No longer inherits from ModemInterface. > > > Diffs > ----- > > CMakeLists.txt 4fa38127bf89695958f712c8770816e7adffac0c > manager.cpp 29e0e0e1ca4276d3ddd0191622e822ccb3438c25 > modemgsmsmsinterface.h fdad802c82ae1f6f805add6c884366e79e2ed658 > modemgsmsmsinterface.cpp 7d248dba6e79d85d22ab5522834cbbe811960175 > modemgsmsmsinterface_p.h d02a2e3df3259be1cf95e7bfbc328af4024f7f21 > smsinterface.h PRE-CREATION > smsinterface.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111366/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Anant Kamath > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
