> On July 2, 2013, 7:18 p.m., Lamarque Souza wrote: > > modemgsmsmsinterface_p.h, line 2 > > <http://git.reviewboard.kde.org/r/111366/diff/3/?file=167581#file167581line2> > > > > You must not remove people's copyright if you are just renaming this > > file.
Wasn't my intention. I guess Git picked it up as a rename. Added the copyrights back (in the next diff) - Anant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111366/#review35474 ----------------------------------------------------------- On July 2, 2013, 6:36 p.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111366/ > ----------------------------------------------------------- > > (Updated July 2, 2013, 6:36 p.m.) > > > Review request for Solid, Lukáš Tinkl and Lamarque Souza. > > > Description > ------- > > Implements > https://developer.gnome.org/ModemManager/0.7/gdbus-org.freedesktop.ModemManager1.Sms.html > Renamed accordingly. > No longer inherits from ModemInterface. > > > Diffs > ----- > > CMakeLists.txt 4fa38127bf89695958f712c8770816e7adffac0c > manager.cpp 29e0e0e1ca4276d3ddd0191622e822ccb3438c25 > modemgsmsmsinterface.h fdad802c82ae1f6f805add6c884366e79e2ed658 > modemgsmsmsinterface.cpp 7d248dba6e79d85d22ab5522834cbbe811960175 > modemgsmsmsinterface_p.h d02a2e3df3259be1cf95e7bfbc328af4024f7f21 > smsinterface.h PRE-CREATION > smsinterface.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111366/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Anant Kamath > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
