> On July 26, 2013, 10:05 a.m., Lukáš Tinkl wrote: > > I'm curious why this is needed, after all, your change just uses a > > different mechanism to connect the signals > > Albert Vaca Cintora wrote: > I'm not sure if the current code actually works, but it gives that error > in runtime so I think it is better to change it anyway. > > Lukáš Tinkl wrote: > Hmm, it works here but... can you test (both cases) whether you get the > signals delivered, e.g. by pulling your battery out of the notebook? > > Albert Vaca Cintora wrote: > I was wrong, It works both ways. I'll close this reviewboard now.
We knew it was working already, thing is that warning Qt is giving us is confusing and misleading. If using QDBusConnection.connect fixes that, I'd say we should change it. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111699/#review36528 ----------------------------------------------------------- On July 28, 2013, 3:07 p.m., Albert Vaca Cintora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111699/ > ----------------------------------------------------------- > > (Updated July 28, 2013, 3:07 p.m.) > > > Review request for Solid and Àlex Fiestas. > > > Description > ------- > > The following message was shown when UPowerManager was instantiated (e.g.: > when kded4 starts): > > Object::connect: No such signal QDBusAbstractInterface::DeviceAdded(QString) > in > /home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:67 > Object::connect: No such signal > QDBusAbstractInterface::DeviceRemoved(QString) in > /home/vaka/kde4/src/kdelibs/solid/solid/backends/upower/upowermanager.cpp:69 > > This patch fixes to connection to the mentioned DBus signal (the normal > connect construction that was used doesn't work for dbus signals) so this > message doesn't appear anymore, and probably fixes the underlying > functionality that required this signal to be connected. > > > Diffs > ----- > > solid/solid/backends/upower/upowermanager.cpp bae234b > > Diff: http://git.reviewboard.kde.org/r/111699/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Albert Vaca Cintora > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
