----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113404/#review42223 -----------------------------------------------------------
Ship it! Ship It! - Lukáš Tinkl On Oct. 23, 2013, 4:36 p.m., Rex Dieter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113404/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 4:36 p.m.) > > > Review request for Solid and Àlex Fiestas. > > > Repository: kdelibs > > > Description > ------- > > Afiestas suggested improving on > https://projects.kde.org/projects/kde/kdelibs/repository/revisions/a8d3d3321522d35c2852abb02a475c6b43be5cfe > To fix build against libudev < 167 , instead of disabling udev solid backend > altogether, only omit the piece that needs the newer api. > > Gratuitously added pkgconfig HINTS too, but can omit that part if it is > considered unwanted. > > > Diffs > ----- > > cmake/modules/FindUDev.cmake 4c8390d > solid/solid/backends/shared/udevqt.h 228687e > solid/solid/backends/shared/udevqtdevice.cpp d18b616 > solid/solid/config-solid.h.cmake 84c3b5c > > Diff: http://git.reviewboard.kde.org/r/113404/diff/ > > > Testing > ------- > > Builds now succeed on rhel6/centos6 hosts that failed previously. > > > Thanks, > > Rex Dieter > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
