----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114433/ -----------------------------------------------------------
Review request for Solid and Àlex Fiestas. Repository: bluedevil Description ------- When a non-existent device is handed to the input helper via the command line it crashes because it gets back a null device. This adds a check for that. Bonus fixes: * qApp->exit() only works when called after the event loop is set up; so delay the init of the helper with a singleshot timer; this allows the process to actually exit instead of just hanging * compiler warning about an unused variable in main.cpp Diffs ----- src/actionplugins/input/helper/inputhelper.h c7b7030 src/actionplugins/input/helper/inputhelper.cpp db9a0b7 src/actionplugins/input/helper/main.cpp 7fca8f2 Diff: http://git.reviewboard.kde.org/r/114433/diff/ Testing ------- Tried it with invalid device addresses as well as valid ones, both from the command line and from the bluedevil systray icon. Thanks, Aaron J. Seigo
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
