-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114676/#review46206
-----------------------------------------------------------

Ship it!


Looks good, please push !

- Àlex Fiestas


On Dec. 26, 2013, 11:13 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114676/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 11:13 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Dan Vrátil.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> -------
> 
> Make valgrind happy.
> 
> 
> ==3179== Conditional jump or move depends on uninitialised value(s)
> ==3179==    at 0x252E7107: KScreen::Output::setType(KScreen::Output::Type) 
> (output.cpp:187)
> ==3179==    by 0x25722BB2: XRandROutput::toKScreenOutput(KScreen::Config*) 
> const (xrandroutput.cpp:353)
> ==3179==    by 0x2571963A: XRandRConfig::toKScreenConfig() const 
> (xrandrconfig.cpp:111)
> ==3179==    by 0x250877B4: KScreenDaemon::monitorConnectedChange() 
> (daemon.cpp:196)
> ==3179==    by 0x25087E5E: KScreenDaemon::KScreenDaemon(QObject*, 
> QList<QVariant> const&) (daemon.cpp:72)
> ==3179==    by 0x25088967: QObject* 
> KPluginFactory::createInstance<KScreenDaemon, QObject>(QWidget*, QObject*, 
> QList<QVariant> const&) (kpluginfactory.h:477)
> ==3179==    by 0x6C383E2: KPluginFactory::create(char const*, QWidget*, 
> QObject*, QList<QVariant> const&, QString const&) (kpluginfactory.cpp:203)
> ==3179==    by 0x4E3CB99: Kded::loadModule(KSharedPtr<KService> const&, bool) 
> (kpluginfactory.h:507)
> ==3179==    by 0x4E3D3C0: Kded::initModules() (kded.cpp:269)
> ==3179==    by 0x4E3D946: Kded::recreateDone() (kded.cpp:578)
> ==3179==    by 0x4E3D9B2: Kded::recreate(bool) (kded.cpp:548)
> ==3179==    by 0x4E3FDFC: KDEDApplication::newInstance() (kded.cpp:818)
> 
> 
> Diffs
> -----
> 
>   src/output.cpp 86e9c0b 
> 
> Diff: https://git.reviewboard.kde.org/r/114676/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
Kde-hardware-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Reply via email to