----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115229/#review48063 -----------------------------------------------------------
I will basically hardcode 1 in xrandr11 backend, the rest is all good to go. Is this closing any bug/crash? if so, should I make a release? backends/xrandr1.1/xrandr11.cpp <https://git.reviewboard.kde.org/r/115229/#comment34022> remove the extra ; backends/xrandr1.1/xrandr11.cpp <https://git.reviewboard.kde.org/r/115229/#comment34021> These were added with XRandR 1.2, see http://cgit.freedesktop.org/xorg/proto/randrproto/tree/randrproto.txt xrandr11 only can handle 1 screen (actually only the X virutal screen), so nothing to do here. - Àlex Fiestas On Jan. 22, 2014, 3:35 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115229/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 3:35 p.m.) > > > Review request for Solid and Àlex Fiestas. > > > Repository: libkscreen > > > Description > ------- > > Config::canBeApplied() now rejects Configs that have more enabled outputs > than is supported by GPU. We can't rely on drivers handling this situation, > some don't (yup, looking at you, nouveau). > > The maximum number of enabled outputs is exposed via a Screen property. In > case of XRandR backends, this returns number of available CRTCs. > > > I will also add a check to KScreen KCM that will show an error and won't > allow applying such configuration. > > > Diffs > ----- > > backends/fake/parser.cpp f1f5d81 > backends/xrandr/xrandrscreen.cpp d43aab1 > backends/xrandr1.1/xrandr11.cpp b201181 > src/config.cpp a473c2b > src/screen.h c85c7c2 > src/screen.cpp 4446d7c > tests/configs/multipleclone.json 12ef4c0 > tests/configs/multipleoutput.json 2b4a8d6 > tests/configs/singleOutputWithoutPreferred.json 4e39647 > tests/configs/singleoutput.json da5d08f > tests/configs/singleoutputBroken.json e3d88cb > tests/configs/tooManyOutputs.json PRE-CREATION > tests/testscreenconfig.cpp f40ea22 > > Diff: https://git.reviewboard.kde.org/r/115229/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
