> On Jan. 24, 2014, 11:05 a.m., Kevin Krammer wrote: > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 48 > > <https://git.reviewboard.kde.org/r/115271/diff/2/?file=235792#file235792line48> > > > > const QString
fixed > On Jan. 24, 2014, 11:05 a.m., Kevin Krammer wrote: > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 52 > > <https://git.reviewboard.kde.org/r/115271/diff/2/?file=235792#file235792line52> > > > > space after if keyword fixed > On Jan. 24, 2014, 11:05 a.m., Kevin Krammer wrote: > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 53 > > <https://git.reviewboard.kde.org/r/115271/diff/2/?file=235792#file235792line53> > > > > why float? pattern looks like an int, function argument is a uint My fault. Copied from the upstart part. Fixed - Raymond ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115271/#review48189 ----------------------------------------------------------- On Jan. 24, 2014, 11:29 a.m., Raymond Wooninck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115271/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 11:29 a.m.) > > > Review request for Solid and Lukáš Tinkl. > > > Repository: kde-workspace > > > Description > ------- > > The upcoming version of systemd (currently git master) seems to have its > version string changed. Up to version 208, the string returned was "systemd > xxx". With the current git master, only the version is returned. The version > check within powerdevil is still expecting to get "systemd xxx" back and > therefore fails with the systemd git master. > > The patch checks first if the "systemd xxx" string is returned and if not, it > checks if just "xxx" is returned. > > > Diffs > ----- > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp eae5436 > > Diff: https://git.reviewboard.kde.org/r/115271/diff/ > > > Testing > ------- > > Testing done on a system with systemd git master and there the suspend and > hibernate options are available again. > > > Thanks, > > Raymond Wooninck > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
