----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117129/#review54405 -----------------------------------------------------------
libs/editor/connectiondetaileditor.cpp <https://git.reviewboard.kde.org/r/117129/#comment38025> Just confirming that Plasma NM 0.9.0.x disables autoconnect for wifi shared connections. Your patch also disables autoconnect for wired shared connections, which is correct too. - Lamarque Souza On March 27, 2014, 9:21 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117129/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 9:21 p.m.) > > > Review request for Solid. > > > Repository: plasma-nm > > > Description > ------- > > IMHO, in most case, shared connection is only a temporarily solution for > people who just want to use if they need to share. But with auto connection > to be true by default, it will make wifi doesn't scan (when connect to adhoc > or use ap will pervent wifi scan), since shared connection is always > available, this is very inconvinient for wifi user. > > And IIRC, shared connection without autoconnection enabled by default is also > the old beaviour of old nm. > > > Diffs > ----- > > libs/editor/connectiondetaileditor.cpp 83e0734 > > Diff: https://git.reviewboard.kde.org/r/117129/diff/ > > > Testing > ------- > > work as expected. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
