----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117298/#review54804 -----------------------------------------------------------
This review has been submitted with commit de38db6b97264a82dca25f7e663ff2e8791bc804 by Dan Vrátil to branch master. - Commit Hook On April 1, 2014, 2:18 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117298/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 2:18 p.m.) > > > Review request for Solid and Àlex Fiestas. > > > Repository: libkscreen > > > Description > ------- > > After disabling an output, we have to force-update the XRandROutput, because > right after that we receive RRNotify_CRTCChange signal for that very output. > This is propagated to users (like KCM), which then call canBeApplied(). > canBeApplied() compares the KScreen::Config with the *outdated* XRandRConfig > and that leads to a crash (because the XRandRConfig still claims that the > output is enabled). > > By updating the cache right after we disable the output, when KCM calls > canBeApplied(), it's Config is compared to an up-to-date Config and > everything is fine. > > > Diffs > ----- > > backends/xrandr/xrandrconfig.cpp 04b37bd > > Diff: https://git.reviewboard.kde.org/r/117298/diff/ > > > Testing > ------- > > Disabled a screen about 20 times without a single crash. Previously I was > able to reproduce 100% of the time. > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
