----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121526/#review72109 -----------------------------------------------------------
Ship it! Ship It! - Jan Grulich On Pro. 15, 2014, 8:30 odp., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121526/ > ----------------------------------------------------------- > > (Updated Pro. 15, 2014, 8:30 odp.) > > > Review request for Solid and Jan Grulich. > > > Repository: plasma-nm > > > Description > ------- > > m_connecting is not always maintained correctly, thus it causes some problem > on plasmoid side. In the old code, if there are multiple connections, > activeConnectionDestroy might set connecting to wrong value if there's > another connection connecting. > > This patch introduce ConnectionIcon::setStates() function, which always scan > through all active connections (number of active connections is relatively > small so it won't affect performance), and set connecting to true if any > connection is in "Activtating" state. > > This patch also introduces > set{Connecting,ConnectionIcon,ConnectionTooltipIcon,Vpn,Limited} function, to > emit the corresponding signal when the value actually changes. > > Some old code in activeConnectionAdded is now moved to addActiveConection, > whose job is to connect to the destroyed signal and state changed signal on > active connection. actionConnectionAdded now calls addActiveConnection() and > setStates() to preserve the old behavior. This separation is also necessary > for the constructor so we can call setStates() only once in the constructor. > > Another small change in QML is to stop busy indicator when plasmoid is not > expanded, or busy indicator is not visible. > > > Diffs > ----- > > applet/contents/ui/ConnectionItem.qml 480ce99 > libs/declarative/connectionicon.h e6e28af > libs/declarative/connectionicon.cpp 7e76a0a > > Diff: https://git.reviewboard.kde.org/r/121526/diff/ > > > Testing > ------- > > Connect on a wifi connection when wifi is connected now correctly triggers > busy indicator in compact representation. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-hardware-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-hardware-devel
