----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121677/#review73828 -----------------------------------------------------------
Ship it! Ship It! - Lamarque Souza On Dec. 26, 2014, 7:46 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121677/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2014, 7:46 a.m.) > > > Review request for Solid and Lukáš Tinkl. > > > Repository: plasma-nm > > > Description > ------- > > Current problems: > 1. if user selects manual provider, apn text is not editable. > 2. if user select "not listed" in apn page, and go back to provider page and > go next again, apn text will be editable while it shouldn't. > 3. a redundant separator if there's on "My plan is not listed...". > > This change reuses slotEnablePlanEditBox function to set mApnText to correct > state, and remove a separator if it's manually set provider. > > > Diffs > ----- > > libs/editor/widgets/mobileconnectionwizard.cpp 29ce4f7 > > Diff: https://git.reviewboard.kde.org/r/121677/diff/ > > > Testing > ------- > > problems above are fixed. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
