----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125963/ -----------------------------------------------------------
Review request for Solid. Repository: solid Description ------- Don't use QVariant for property values because libudev only works with strings, so it makes no sense to convert it to QVariant. Device::decodedDeviceProperty() was removed because it's not used anywhere. It was unescaping backslashes and converting hex->dec, but that should do the user of the library if necesary. Also drop support for building with very old libudev versions. Diffs ----- src/solid/devices/backends/shared/udevqt_p.h 19096f9 src/solid/devices/backends/shared/udevqtclient.h bf42d38 src/solid/devices/backends/shared/udevqtclient.cpp e268cf4 src/solid/devices/backends/shared/udevqtdevice.h 1a50d4b src/solid/devices/backends/shared/udevqtdevice.cpp b6da78f src/solid/devices/backends/udev/udevdevice.cpp 9fb5e09 src/solid/devices/backends/udev/udevmanager.cpp 3f3a671 src/solid/devices/backends/udisks2/udisksopticaldisc.cpp a9d9c6b src/solid/devices/backends/udisks2/udisksstoragedrive.cpp af49063 Diff: https://git.reviewboard.kde.org/r/125963/diff/ Testing ------- Builds Thanks, David Rosca
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
