> On Nov. 23, 2015, 4:17 nachm., Thomas Lübking wrote: > > +1 > > Functional patch looks fine, since the extension is not gonna mystically > > show up, one may wish to cache extension status validity in a tenary member > > (iff this constructor is called more often) > > > > Can't tell about "unrelated changes policy" in the component ;-)
The constructor is called only once on startup of PowerDevil when UPower backend is initialized and with it XRandrBrightness - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126146/#review88726 ----------------------------------------------------------- On Nov. 23, 2015, 4 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126146/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 4 nachm.) > > > Review request for Solid and Thomas Lübking. > > > Bugs: 352462 > https://bugs.kde.org/show_bug.cgi?id=352462 > > > Repository: powerdevil > > > Description > ------- > > Check whether the extension is there before calling into it. > > Also cache calls to QX11Info::connection() if we're at it. > > > Diffs > ----- > > daemon/backends/upower/xrandrbrightness.cpp 0abcefe > > Diff: https://git.reviewboard.kde.org/r/126146/diff/ > > > Testing > ------- > > Still works, didn't test without xrandr. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
