-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127656/
-----------------------------------------------------------
(Updated April 19, 2016, 7:52 a.m.)
Review request for Solid, Àlex Fiestas, Daniel Vrátil, and Sebastian Kügler.
Changes
-------
correct email address in patch
Bugs: 356228
http://bugs.kde.org/show_bug.cgi?id=356228
Repository: libkscreen
Description
-------
When rotating a single screen to portrait and back to landscape, the XRandR
screen size is not updated.
When for example rotating a display of 1920x1080 portrait, the screen size is
changed to 1080x1920. XRandR::screenChanged() however is called with rotation =
90 and size = 1920x1080. So the screen size stored internally remains
1920x1080, instead of being updated to 1080x1920.
When you then rotate the screen back to landscape, it checks the new screen
size (1920x1080) against the stored (1920x1080) and does not update the screen
size (which is at this point 1080x1920).
This should solve https://bugs.kde.org/show_bug.cgi?id=356228 which has photos
of the incorrect behavior.
Diffs (updated)
-----
backends/xrandr/xrandr.cpp a11b708059e8d1de9a67ca7846ae2e633fb1deee
Diff: https://git.reviewboard.kde.org/r/127656/diff/
Testing
-------
- Rotate single screen to portrait and back to landscape
- Rotate one screen of dual head to portrait and back
- Rotate both screens of a dual head setup to portrait and back
Thanks,
Pieterjan Camerlynck
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
