> On Nov. 16, 2016, 2:37 a.m., Christoph Feck wrote: > > Any hope that this could have fixed the cause for bug 345871?
Can't comment on that, since I've been developing on FreeBSD, and our UDisks2 implementation doesn't handle partitions properly yet. - Gleb ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129277/#review100864 ----------------------------------------------------------- On Oct. 31, 2016, 1:49 p.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129277/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 1:49 p.m.) > > > Review request for Solid. > > > Repository: solid > > > Description > ------- > > This patch replaces uses of `typedef QList<QByteArray> ByteArrayList;` with > built-in `QByteArrayList` type. This type was in Qt since 5.4, while Solid > requires 5.5. > > > Diffs > ----- > > src/solid/devices/backends/udisks2/udisks2.h 0abf915 > src/solid/devices/backends/udisks2/udisksdevice.cpp 5283c2a > src/solid/devices/backends/udisks2/udisksmanager.cpp 1e149c2 > src/solid/devices/backends/udisks2/udisksstorageaccess.cpp 1bd6acf > > Diff: https://git.reviewboard.kde.org/r/129277/diff/ > > > Testing > ------- > > Compiles, mounting works. > > > Thanks, > > Gleb Popov > >
