-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6054/
-----------------------------------------------------------
Review request for Network Management and KNetworkManager.
Summary
-------
This patch adds support for password protected keys when using OpenVPN. This
fixes long standing bug 150680.
I have added a text field called "Key password" to the configuration parameters
for connection types "Certificates" and "Certificates with password". At the
same time I fixed other issues in the UI file: changed tab order, added missing
buddy's and masked password fields.
The rest was easy: the "Key password" value will be stored as a "secret". The
NetworkManager daemon receives this "cert-pass" value and connects successfully.
This addresses bug 150680.
https://bugs.kde.org/show_bug.cgi?id=150680
Diffs
-----
trunk/extragear/base/networkmanagement/vpnplugins/openvpn/openvpnprop.ui
1203426
trunk/extragear/base/networkmanagement/vpnplugins/openvpn/openvpnwidget.cpp
1203426
Diff: http://svn.reviewboard.kde.org/r/6054/diff
Testing
-------
I have tested "Certificates" mode with and without a password protected key. In
case your key is not protected, you should not fill in the "Key password"
field. But if you do, it will be erased after a successful login (I believe
this is caused by NetworkManager sending us updated data). Not really an issue
IMO.
I also tested "Certificates with password" mode. I do not have such a setup,
but it seems to work in the same way as "Certificates" and ignores my provided
username/password values.
Thanks,
Andy
_______________________________________________
kde-networkmanager mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-networkmanager
