----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100835/#review1886 -----------------------------------------------------------
Patch seems to work as advertised in a couple hours worth of testing (on f15), flipping my wifi killswich on/off a bunch. - Rex On March 10, 2011, 4:10 p.m., Jirka Klimes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100835/ > ----------------------------------------------------------- > > (Updated March 10, 2011, 4:10 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > This patch fixes "Enable ..." checkbox handling and simplify the code. > > There was a bug that when Wifi was rfkilled by a hardware switch, > knm unchecked the "Enable wireless" checkbox, but it also (erroneously) > issued 'disable wireless' command, which caused NM to store 'wireless > disabled' state as user preference. Then after enabling hardware switch > WiFi stayed disabled. > This is now fixed and the code is also simplified a bit. > > Would you review please? > > For Lamarque: > I think that b1c517b2b42a62990b6f9dd5b96eb79659e9953b (saving config) is not > necessary and may be contra-productive. > NM itself stores user preference and there's no need applets do that. If > there are more applets they will step on their toes. > And in NM 0.9 will be perfectly possible to have more applets running. > Nonetheless, thanks for your work on knm! > > > Diffs > ----- > > applet/nmpopup.cpp 282299b > > Diff: http://git.reviewboard.kde.org/r/100835/diff > > > Testing > ------- > > > Thanks, > > Jirka > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
