----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100857/#review1948 -----------------------------------------------------------
vpnplugins/vpnc/vpncauth.cpp <http://git.reviewboard.kde.org/r/100857/#comment1638> Does this patch fix http://bugs.kde.org/241798 ? If so could you please add that bug in your review request's header? - Lamarque Vieira On March 14, 2011, 6:30 p.m., Andrey Borzenkov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100857/ > ----------------------------------------------------------- > > (Updated March 14, 2011, 6:30 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > secretsType is expected to have the same keys as secrets themselves. > vpnc was erroneously using old setting names for them, so secrets > were always saved even if user requested type "do not save" in config. > > Group storage type was always ignored due to copy'n'paste error > > > Diffs > ----- > > vpnplugins/vpnc/vpncauth.cpp eeeb00d > vpnplugins/vpnc/vpncwidget.cpp 71c828b > > Diff: http://git.reviewboard.kde.org/r/100857/diff > > > Testing > ------- > > Tested with current GIT master. > > > Thanks, > > Andrey > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
