----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100975/ -----------------------------------------------------------
Review request for Network Management. Summary ------- Currently secrets are stuck in wallet forever. This patch adds method to delete them and applies it when connection is deleted. As it touches rather sensitive issues I would like public review. Existing remnants still need to be removed manually. TODO: ensure plain text secrets are deleted when encrypted storage is configured (is mostly mechanical - set secrets to "" - but touches many files so I'd like to postpone it until systemwide patch is settled) TODO: ensure secrets are moved as appropriate when storage type is changed. I am still not sure where to do it. Diffs ----- libs/internals/connectionpersistence.h 26985cbea6ab6e6d38117f931db437177943066a libs/internals/connectionpersistence.cpp 7c52bb14b5f351fef74328c76bf4a26f3cc8f515 settings/config/manageconnectionwidget.cpp 15a6251f086a679e26eb212697c004de2b532ebd Diff: http://git.reviewboard.kde.org/r/100975/diff Testing ------- Tested on top of systemwide and works there. Compile-tested on top of master. Thanks, Andrey
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
