----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101117/#review2666 -----------------------------------------------------------
backends/NetworkManager/settings/ipv6dbus.cpp <http://git.reviewboard.kde.org/r/101117/#comment2362> Why are you using a QStringList here? AddressArg is a QList<IpV6AddressMap> according to Ipv6DBus::toMap() and IpV6AddressMap is a struct, not a QString. - Lamarque Vieira On April 14, 2011, 1:38 p.m., Ilia Kats wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101117/ > ----------------------------------------------------------- > > (Updated April 14, 2011, 1:38 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > The last IPv4 blocks have been assigned, so IPv6-support in KDE network > management is long overdue. Attached patch makes that possible. > > > This addresses bug 270827. > http://bugs.kde.org/show_bug.cgi?id=270827 > > > Diffs > ----- > > backends/NetworkManager/CMakeLists.txt f6ff372 > backends/NetworkManager/connectiondbus.cpp 4a142e9 > backends/NetworkManager/settings/ipv4dbus.cpp f77d421 > backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION > backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION > libs/internals/CMakeLists.txt d5a0dab > libs/internals/connection.cpp 3cd7e78 > libs/internals/connectionpersistence.cpp 8396464 > libs/internals/schemas/ipv4.kcfg a069ef8 > libs/internals/schemas/ipv6.kcfg PRE-CREATION > libs/internals/schemas/ipv6.kcfgc PRE-CREATION > libs/internals/setting.cpp 197fafc > libs/internals/settings/ipv4.h fee2987 > libs/internals/settings/ipv4.cpp 6c6fd64 > libs/internals/settings/ipv4persistence.cpp c30622d > libs/internals/settings/ipv6.h PRE-CREATION > libs/internals/settings/ipv6.cpp PRE-CREATION > libs/internals/settings/ipv6persistence.h PRE-CREATION > libs/internals/settings/ipv6persistence.cpp PRE-CREATION > libs/ui/CMakeLists.txt aea6563 > libs/ui/gsmconnectioneditor.cpp 5a26c7c > libs/ui/ipv4.ui e107869 > libs/ui/ipv4widget.cpp 732a94e > libs/ui/ipv6.ui PRE-CREATION > libs/ui/ipv6advanced.ui PRE-CREATION > libs/ui/ipv6advancedwidget.h PRE-CREATION > libs/ui/ipv6advancedwidget.cpp PRE-CREATION > libs/ui/ipv6widget.h PRE-CREATION > libs/ui/ipv6widget.cpp PRE-CREATION > libs/ui/pppoepreferences.cpp 0cabcd0 > libs/ui/simpleipv6addressvalidator.h PRE-CREATION > libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION > libs/ui/vpnpreferences.cpp 5274d14 > libs/ui/wiredpreferences.cpp 60b7932 > libs/ui/wirelesspreferences.cpp 7f901c2 > solidcontrolfuture/CMakeLists.txt 4643e8d > solidcontrolfuture/networkipv6config.h PRE-CREATION > solidcontrolfuture/networkipv6config.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101117/diff > > > Testing > ------- > > Only on my local system, compared qdbus output with nm-applet and > knetworkmanager, as well as created ad-hoc wlan connections and checked with > ifconfig. My university's network does currently not support IPv6, so a field > test could not be done. > > > Screenshots > ----------- > > Basic settings > http://git.reviewboard.kde.org/r/101117/s/125/ > advanced settings > http://git.reviewboard.kde.org/r/101117/s/126/ > > > Thanks, > > Ilia > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
