----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101161/#review2772 -----------------------------------------------------------
This review has been submitted with commit 0f7b63d3fee6fefe0afd95af782fb4b50a212b26 by Lamarque V. Souza. - Commit On April 20, 2011, 3:43 p.m., Ilia Kats wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101161/ > ----------------------------------------------------------- > > (Updated April 20, 2011, 3:43 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > Resizing the QByteArray gives us 6 uninitialized elements, which can be > converted to a string. This results in a completely unrelated mac address > showing up on all connection which are restricted to "Any". > > > Diffs > ----- > > libs/internals/settings/802-11-wireless.h 436e219 > libs/internals/settings/802-3-ethernet.h 9f13796 > > Diff: http://git.reviewboard.kde.org/r/101161/diff > > > Testing > ------- > > > Screenshots > ----------- > > before > http://git.reviewboard.kde.org/r/101161/s/133/ > after > http://git.reviewboard.kde.org/r/101161/s/134/ > > > Thanks, > > Ilia > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
